search

mpcjanssen / simpletask-android

GNU General Public License v3.0
546 stars 125 forks source link

Use okhttp 4.10.0-RC1 #1208

Closed chadvoegele closed 1 year ago

chadvoegele commented 1 year ago

Hi @mpcjanssen!

Back in 2020, I was having some trouble with a stream was reset: NO_ERROR error that was fixed by using okhttp version 4.10.0-RC1. https://github.com/mpcjanssen/simpletask-android/issues/1099

It looks like a change was made a year ago to 'not vendor Sardine' which reverted okhttp back to 4.9.0, and reintroduced the error. https://github.com/mpcjanssen/simpletask-android/commit/e10108322734df2bb222e83874e78542fbaddb09

Would it be possible to flip to 4.10.0-RC1 again?

For some reason, 4.10.0 is not working but 5.0.0-alpha.10 is. If a 5.0.0 version is ever released, there would be some hope to not use a RC version. If you want, I could instead try to upgrade the okhttp version in sardine-android.

Thanks!

mpcjanssen commented 1 year ago

Merged, thanks

chadvoegele commented 1 year ago

Thank you!

wangsuicheng commented 1 year ago

I would like to ask if the stable version of okhttp 4.10.0 has fixed this problem? or can only use the RC-1 version?

Thank you~~ @chadvoegele