mpcjanssen / simpletask-android

GNU General Public License v3.0
546 stars 125 forks source link

Switch to reactive framework for UI and other updates #904

Open mpcjanssen opened 6 years ago

mpcjanssen commented 6 years ago

The timing and triggering of UI updates and todo updates based on events and modifications is becoming fairly convoluted leading to several issues (e.g. #820, #901).

The proper way to fix this is to make all updates based on reactive streams.

mpcjanssen commented 6 years ago

Seems that removing some layers of events might be an equally valid approach.

smichel17 commented 6 years ago

Which layers?

mpcjanssen commented 6 years ago

the use of broadcast events just to update the local UI and the at this point overuse of invalidateOptionsMenu. Just updating the appropriate parts of the UI seems more direct and easier to reason about.

mpcjanssen commented 6 years ago

Using a single point to trigger UI updates using a certain type of event seems to work very well without adding further indirection