search

mpclarkson / StravaSwift

A Swift wrapper for the Strava API v3
MIT License
102 stars 45 forks source link

Fix Multipart Upload for /uploads to work #13

Open wizapp opened 6 years ago

wizapp commented 6 years ago

Hi,

For current Strava API, /upload API needs file data to be named "file" in multipart Data. So here is my fix that makes my project working now.

Cheers Sebastien

lludo commented 4 years ago

Thank you for this! Is this still the case? Is this in the documentation?

ehmjaysee commented 4 years ago

Uploading activities in the main purpose I was looking into StravaSwift. This looks like a trivial code change so hoping this can get pulled in soon.

DominicHolmes commented 4 years ago

Can confirm that version 1.0.1 doesn't work, but implementing this change lets me successfully upload .gtx files. Thanks so much @wizapp !

See my fork with version 1.0.2 if you want this fix implemented.

@mpclarkson you should consider merging this :)

lludo commented 4 years ago

Great work, thank you! Can you create a pull request by any chance?

On Tue, Apr 14, 2020 at 4:33 PM dominic notifications@github.com wrote:

Can confirm that version 1.0.1 doesn't work, but implementing this change lets me successfully upload .gtx files. Thanks so much @wizapp https://github.com/wizapp !

See my fork https://github.com/DominicHolmes/StravaSwift with version 1.0.2 if you want this fix implemented.

@mpclarkson https://github.com/mpclarkson you should consider merging this :)

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mpclarkson/StravaSwift/pull/13#issuecomment-613731924, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE2GTWCX6WNT2NCLDSR6QTRMTXE7ANCNFSM4EMN76GA .

-- Thank you, Ludovic Landry