search

mpclarkson / StravaSwift

A Swift wrapper for the Strava API v3
MIT License
102 stars 45 forks source link

Swift 3.0 issues #4

Closed agonzalezjr closed 7 years ago

agonzalezjr commented 7 years ago

Fixes issues with the Sample App after the recent API changes and tests all requests in the Sample App are working.

I had to revert to using the old authentication method (full standalone browser instead of SFSafariVC) due to display issues in the sample app.

I agree that the SFSafariVC is a better approach, but it will require more changes to the Sample App to get it working. I might have a chance to work on that later, but I wanted to see what you thought about creating a StravaAuthDelegate that is registered on the singleton. This delegate would be notified by the singleton when the auth succeeds (with the token) or fails (with the error).

mpclarkson commented 7 years ago

Thanks @agonzalezjr - I'll merge this in now. Do you have an example implementation for the StravaAuthDelegate? I'll merge this into the main branch too - swift 2 is well behind us now.