search

mpclarkson / icon-scraper

PHP Library to get the apple-touch-icons and favicon from a website.
hilenium.com
Other
21 stars 9 forks source link

Favicon not captured #2

Open mpclarkson opened 9 years ago

mpclarkson commented 9 years ago

http://www.harley-davidson.com/content/h-d/en_AU/home.html//favicon.ico

karstennilsen commented 6 years ago

The problem is that with endRedirect all redirects are first processed. When this is not to a root path e.g. http://www.harley-davidson.com/content/h-d/en_AU/home.html or https://gmail.com redirects to https://accounts.google.com/ServiceLogin?service=mail&passive=true&rm=false&continue=https://mail.google.com/mail/&ss=1&scc=1&ltmpl=default&ltmplcache=2&emr=1&osid=1, you enter an unsupported situation.

E.g. on line 155 of Scraper.php there should be a something that takes the base path in stead of the full $url Line 155: $href = $url . '/' . $href; //Todo: Improve this

Need fixing indeed.