search

mpdairy / elm-component-updater

Easily update and organize nested child components in Elm.
MIT License
41 stars 1 forks source link

Sdaves port to 0.18.0 #1

Closed sdaves closed 7 years ago

sdaves commented 7 years ago

Hello. I had to make these changes to get Updater working in my 0.18.0 project. Let me know if you are interested in merging them.

Thanks!

mpdairy commented 7 years ago

Hey thanks a lot!

mpdairy commented 7 years ago

@sdaves I merged your updates and I updated the examples last night, then bumped it with elm-package bump, but it's still not updated on the repository. Do you know if I have to do anything else, or does it just take a while?

sdaves commented 7 years ago

Tag a new version and push it with git push --tags

On November 17, 2016 12:04:15 PM EST, Matt Parker notifications@github.com wrote:

@sdaves I merged your updates and I updated the examples last night, then bumped it with elm-package bump, but it's still not updated on the repository. Do you know if I have to do anything else, or does it just take a while?

You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/mpdairy/elm-component-updater/pull/1#issuecomment-261305309

mpdairy commented 7 years ago

@sdaves do I have to do anything after git push --tags? I made a new 1.0.1 tag and pushed it, but elm-packages still shows the old one.

sdaves commented 7 years ago

https://github.com/mpdairy/elm-component-updater/blob/master/elm-package.json#L2

Needs to be 1.0.1

On November 18, 2016 11:09:13 AM EST, Matt Parker notifications@github.com wrote:

@sdaves do I have to do anything after git push --tags? I made a new 1.0.1 tag and pushed it, but elm-packages still shows the old one.

You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/mpdairy/elm-component-updater/pull/1#issuecomment-261569969

sdaves commented 7 years ago

git tag -a 1.0.1 -m "0.18 upgrade" git push --tags elm-package publish

On November 18, 2016 3:06:05 PM EST, Stephen Daves stephen@stephendaves.com wrote:

https://github.com/mpdairy/elm-component-updater/blob/master/elm-package.json#L2

Needs to be 1.0.1

On November 18, 2016 11:09:13 AM EST, Matt Parker notifications@github.com wrote:

@sdaves do I have to do anything after git push --tags? I made a new 1.0.1 tag and pushed it, but elm-packages still shows the old one.

You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/mpdairy/elm-component-updater/pull/1#issuecomment-261569969

mpdairy commented 7 years ago

Ok, thanks, I just forgot the elm-package publish part