mpenet / jet

[not maintained, use at own risk] Jetty9 ring server adapter with WebSocket support via core.async and Jetty9 based HTTP & WebSocket clients (jvm based, no cljs)
http://mpenet.github.io/jet/
167 stars 19 forks source link

Guarantees around `ctrl` chan #25

Closed wyegelwel closed 9 years ago

wyegelwel commented 9 years ago

Not an issue as much as a question. What are the guarantees around the ctrl chan.

mpenet commented 9 years ago

Hi, sorry for the delay, I totally missed this. In http context the :ctrl chan is never closed explicitly. You can have errors such as failure to encode/write to the stream there so no reason to close, the controler can handle retries/failures how they like this way.

In websocket context it actually is closed after errors at the moment, since it's used for disconnects/network errors only at this point, but I will/might add error handling to socket writing, the same way it's done with http, so dont' have any expectations on that part.