search

mpenkov / ffmpeg-tutorial

A set of tutorials that demonstrates how to write a video player based on FFmpeg
http://www.ffmpeg.org/documentation.html
1.22k stars 395 forks source link

Stuff that should be closed.. #17

Closed illuusio closed 10 years ago

illuusio commented 11 years ago

I cleaned up a code of tutorial07.c (As it code wans't intended as it should) then I fixed tutorial07.c to play s16p (or fltp) with libavresampler/libswresampler. You can also compile without. I had these all in separated commits but I'm so lousy at git.. this should do..

ghost commented 10 years ago

Hey, thanks for the pull request. I'd like to use your changes, but there's a lot of whitespace changes that make it difficult to see what you actually fixed. Can you remove the whitespace changes from the commit?

illuusio commented 10 years ago

Ok I'll clean this one up for real commit. Actually thing that shoud cherrypicked is last commit. There is audio stuff made work. Other stuff I'll make new pull request.

illuusio commented 10 years ago

This is mainly done with 

astyle --indent=spaces=4 -K -S -j -c --style=java -p --lineend=linux *.c'

but in smaller pieces so you can see more easily what is wanted and what is not.

mpenkov commented 10 years ago

I really don't think we need to fix the whitespace and code formatting. The way it is now, the code can be directly compared to the original tutorials to get a meaningful diff. I think that's more important than making the code look pretty. If we fix the whitespace, then diffing with the original tutorial source will be more difficult.

You mentioned fixing some actual functionality (bugs) in the original pull request. Where are those changes?

illuusio commented 10 years ago

Ok.. readable code ain't your stuff.. so I'll keep up my repo. You can close this pull request and i'll keep up my code.. I'll fixed broken audio in original stuff but i'll do it in my repo with nice code changes.. because if you want to use SDL S16 and have S16P from ffmpeg you should have conversion (libswresampler or libavresampler in this case) to not have ugly sound but it also breaks you precisious compability to orignal so i'll just make it up to myself.