search

mpenning / ciscoconfparse

Parse, Audit, Query, Build, and Modify Arista / Cisco / Juniper / Palo Alto / F5 configurations.
http://www.pennington.net/py/ciscoconfparse/
GNU General Public License v3.0
799 stars 220 forks source link

remove test shebangs #300

Closed devyntk closed 1 month ago

devyntk commented 5 months ago

these cause an issue when packaging on centos9, as they do not specify python2 or python3, and thus panic during building.

mpenning commented 5 months ago

Hello @devyntk

I think the question should be asked why this is a problem to begin with. These shebangs have existed in the code base for years and it's never been a problem. By way of example, all these tests pass github CICD and yet they don't pass centos9 package build process?

However, let's just assume for the moment that there is something new in centos9 that somehow trips over them in the package build process. You have choices:

  1. Do not try to run the tests
  2. Manually chmod the files to remove the execute bit
  3. Manually remove the entire tests/ folder
  4. If you feel you absolutely must run the tests, then run cd tests && pytest . instead of whatever you're doing now.

Thoughts?

github-actions[bot] commented 2 months ago

This PR has automatically been marked stale due to inactivity. It will automatically close unless further action is taken. Please understand that the CiscoConfParse team is not obligated to comment on (or approve) every Pull Request. For more detailed information, please refer to CONTRIBUTING guidance -> https://github.com/mpenning/ciscoconfparse/blob/main/.github/CONTRIBUTING.md

github-actions[bot] commented 1 month ago

This PR has been automatically closed due to lack of activity. For more detailed information, please refer to our CONTRIBUTING guidance -> https://github.com/mpenning/ciscoconfparse/blob/main/.github/CONTRIBUTING.md