mperdeck / LINQtoCSV

Popular, easy to use library to read and write CSV files.
197 stars 112 forks source link

New issues #4

Open lvaleriu opened 10 years ago

lvaleriu commented 10 years ago

1° Reading CSV files without separator char (Add CharLength property in field csv attribute) 2° Using FieldIndex for reading data at the right index in the data row 3° Using OutputFormat (when needed) for parsing values when reading csv fields.

These are features I've needed in several projects.

mperdeck commented 10 years ago

I merged your pull request and published the resulting code to NuGet as version 1.3. I also published the updated article: http://www.codeproject.com/Articles/25133/LINQ-to-CSV-library

Thanks for your contribution! You'll see that you credited you at the end of the article.

However, there are a few issues with the changes you made to the article:

1) In the CsvFileDescription section at http://www.codeproject.com/Articles/25133/LINQ-to-CSV-library#CsvFileDescription there is a link for UseFieldIndexForReadingData, which makes sense because you added a property with that name to CsvFileDescription.

However, the CsvFileDescription section does not contain a description of UseFieldIndexForReadingData.

2) In the CsvColumn Attribute section http://www.codeproject.com/Articles/25133/LINQ-to-CSV-library#CsvColumn_Attribute you added a description for the new property CharLength. But CharLength does not appear in the list of links near the top of the section.

3) Also in the CsvColumn Attribute section, there is now a UseFieldIndexForReadingData link and a UseFieldIndexForReadingData section, even though UseFieldIndexForReadingData is not a property of CsvColumnAttribute.

4) The UseFieldIndexForReadingData section seems to be saying that the operation of the FieldIndex property is modified when UseFieldIndexForReadingData is true. If this section is really about the FieldIndex property, than it should be added to the description of the FieldIndex property higher up.

This is all pretty confusing and messy.

Could you please update the article.htm file.

Thanks,

Matt Perdeck