Closed romansp closed 10 years ago
Thanks Roman. I'm overseas at the moment. Will look at it early Feb when I'm back home.
Thanks Roman. I'm overseas at the moment. Will look at it early Feb when I'm back home.
Hi Roman,
Thanks for your pull request. However, I didn't see any updates to the article.htm file (to document your new feature for users) or updates to the unit tests.
When you add these changes, I'll look at your pull request again.
Matt
Hi, I've added tests and documentation to the article.html file.
Hey Roman, I've merged your pull request.
Consider following file:
Though it's not a canonical representation of CSV file, that trailing separator at the end of the line breaks file reading: reader considers one more
null
column, soContainsKey()
method onnull
value throws an exception.I added
IgnoreTrailingSeparatorChar
property toCsvFileDescription
, so reader ignores trailing separator character at the end of the line.I'm not exactly sure but maybe it should be implemented as a regular feature without additional property to
CsvFileDescription
.Thanks, Roman