search

mperdeck / jsnlog.js

Tiny JavaScript logging library, simple and well documented. Lots of options to filter logging data.
js.jsnlog.com
Other
130 stars 43 forks source link

Remove IE-specific XDomainRequest to allow compilation with newer version of TypeScript #26

Closed tomcorke closed 8 years ago

tomcorke commented 8 years ago

The IE specific window property XDomainRequest was dropped from TypeScript in 1.5

Related issue with discussion: https://github.com/Microsoft/TypeScript/issues/2927 Commit removing XDomainRequest: https://github.com/Microsoft/TypeScript/commit/1dacb54fbde2c2af772326981e6d753f76b1955a

Removing this property may break support for CORS requests in IE8, but I think it's worth it at this point.

The intended side-effect of this change fixes issue https://github.com/mperdeck/jsnlog.js/issues/19

TypeScript now defines __extend like so:

var __extends = (this && this.__extends) || function (d, b) {

This fixes the linked issue and the same issue I was experiencing, where this was not checked before this.__extends was referenced.