search

mperdeck / jsnlog.js

Tiny JavaScript logging library, simple and well documented. Lots of options to filter logging data.
js.jsnlog.com
Other
130 stars 44 forks source link

Disallow logs, if global logging config is disabled #62

Closed Akkora closed 6 years ago

Akkora commented 6 years ago

The logs will not be sent to server nor to console if global logging is disabled. This fixes problems with already added logs to the appenders that should not be sent.

mperdeck commented 6 years ago

Thanks for your pull request.

I saw you stop jsnlog.js from sending out more log items by adding these lines: if (allow(this)) { return; }

However, shouldn't that be negated? if (!allow(this)) { return; }

Did you test this change?

Akkora commented 6 years ago

You are right, I just fixed it and tested it. It is working now.

Akkora commented 6 years ago

Did you have a chance to test this?

mperdeck commented 6 years ago

I had now. Sorry for the late response. Thanks for the pull request.