Open mperezbazan opened 1 year ago
Good job so far, done There are some issues that you still need to work on to go to the next project but you are almost there!
Good job with adding descriptions for all the cards :+1:
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding! clapclapclap
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi team,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations and well done! 🎉
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In this issue, we want to tell you that we created this project, for the Ruby Capstone Project You can access the kanban boards at the following link: https://github.com/mperezbazan/catalog-of-my-things/projects/1
We are 3 students in the team and we do the following assignment: Team Member 1: @mperezbazan Team Member 2: @emmanuellmhango Team Member 3: @amexabee