search

mperham / connection_pool

Generic connection pooling for Ruby
MIT License
1.63k stars 143 forks source link

mperham/connection_pool#113 expose pool from Wrapper #114

Closed ook closed 5 years ago

ook commented 5 years ago

Expose pool from ConnectionPool::Wrapper

See #113

mperham commented 5 years ago

I'd like the method to be a little more explicit, maybe wrapped_pool?

mperham commented 5 years ago

And can you add an access in the test suite to exercise it?

ook commented 5 years ago

Hi @mperham thank you for your interest. I changed the method name as requested. What do you mean by "adding an access in the test suite"? I added a test to check the method correctly expose the ConnectionPool, but maybe it's not sufficient?

mperham commented 5 years ago

Thank you!

aliou commented 5 years ago

Hello @mperham, do you know when this will be available in a new version of the gem ? Thanks! (also Hi @ook!)