search

mperham / connection_pool

Generic connection pooling for Ruby
MIT License
1.63k stars 143 forks source link

Fix argument forwarding in Ruby 2.7 #149

Closed qnighy closed 3 years ago

qnighy commented 3 years ago

Fixes https://github.com/mperham/connection_pool/issues/148.

In Ruby 2.7 keyword arguments are not yet separated from positional ones. **kwargs was seemingly introduced here to suppress warnings, but for accuracy we need to remove **kwargs and just add ruby2_keywords.

qnighy commented 3 years ago

Thanks for the quick merge! A patch release would be helpful.

mperham commented 3 years ago

Yes, in the morning. Thank you for the patch.

On Tue, Apr 13, 2021 at 19:03 Masaki Hara @.***> wrote:

Thanks for the quick merge! A patch release would be helpful.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/mperham/connection_pool/pull/149#issuecomment-819167680, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAWX7X6CXRO64WSX5QKGDTITZYVANCNFSM4227VVYA .

mperham commented 3 years ago

Done.

qnighy commented 3 years ago

Thanks!