search

mperham / connection_pool

Generic connection pooling for Ruby
MIT License
1.63k stars 143 forks source link

Prefer `require_relative` for internal requires #152

Closed deivid-rodriguez closed 3 years ago

deivid-rodriguez commented 3 years ago

Since it's faster and doesn't need to mess with the $LOAD_PATH. This is how it was historically done, but it was changed at https://github.com/mperham/connection_pool/commit/dd5dac56607a146aa29ec4ef557c42726541a2fa.

Since changing that seems unrelated to that change, I'd like to go back to require_relative if possible.

This is particularly helpful for me as a maintainer of bundler, because bundler includes a vendored copy of this library, and we really don't want to mess with the $LOAD_PATH at the time we require it. Including this change allows us to vendor the library completely unmodified.

deivid-rodriguez commented 3 years ago

Thanks! :heart_eyes: