Use explicit namespaces for `Mutex` and `ConditionVariable`

mperham / connection_pool

Generic connection pooling for Ruby

MIT License

1.63k stars 143 forks source link

Closed deivid-rodriguez closed 3 years ago

deivid-rodriguez commented 3 years ago

This upstreams this PR to the rubygems repository: https://github.com/rubygems/rubygems/pull/4709.

Using the explicit Thread namespace is the future-proof way of accessing these constants.

deivid-rodriguez commented 3 years ago

Thanks for merging! :heart:

I noticed though that according to https://github.com/rubygems/rubygems/pull/4709#issuecomment-870127055, Thread::Mutex was introduced on ruby 2.3, and this library supports down to ruby 2.2 included. So this will break ruby 2.2 support.

I can:

Create a PR bumping the minimum supported ruby to 2.3.
Create a PR reverting this PR, and will keep our custom patch until you drop support.

Let me know which one you prefer.

mperham commented 3 years ago

We can drop 2.2, but let’s bump our version to 2.3 and add it to the changelog.