search

mperham / connection_pool

Generic connection pooling for Ruby
MIT License
1.63k stars 143 forks source link

Don’t pass disconnect through redis-namespace connection. Closes resque/... #72

Closed substars closed 9 years ago

substars commented 9 years ago

...redis-namespace#98 and closes mperham/sidekiq#2213.

Not super pretty, but does the trick.

substars commented 9 years ago

redis-namespace appears to have removed all the administrative commands from the list of commands it knows about in recent releases, so it looks like they want you to access the connection directly for this sort of thing.

mperham commented 9 years ago

I can't agree with this PR. redis-namespace can't have its cake and eat it too. If it wants to be a transparent wrapper around the redis connection, it has to wrap everything.