search

mperham / connection_pool

Generic connection pooling for Ruby
MIT License
1.63k stars 143 forks source link

Add Rubocop #80

Closed tamird closed 9 years ago

tamird commented 9 years ago

@mperham thoughts?

mperham commented 9 years ago

What's the purpose?

tamird commented 9 years ago

In my experience RuboCop can find subtle bugs resulting from weird patterns. In this case, most of the change is whitespace, so it's really just a regression net.

Truthfully I came across this branch while cleaning out some old work and decided to get your opinion. I no longer work in Ruby so I don't feel strongly either way.

mperham commented 9 years ago

I'd prefer to leave stable code as is, even if the style might be unconventional, unless there's an obvious win.