PID detection is broken for sysvinit

tioteath commented 8 years ago

subj. due to this code:

    paths := []string{
        i.varrunPath + serviceName + ".pid",
        i.varrunPath + serviceName + "/" + serviceName + ".pid",
    }

So PID file names are hardcoded and it seems there's no way to set that path manually. Like half of sysvinit's services set its own PID's name in /run, mine is /run/postgresql/9.3-main.pid, so it must be possible to point inspeqtor to proper one, as those locations are in correspondence with the standard (it doesn't enforces PID names, only paths, as far as I know .

Settings symlinks is not an option, as it must be performed each reboot and there's no good place to put this symlink creation code to. Changing init script, provided by the package is allways the worst option.

jwmarshall commented 8 years ago

I have the same issue with postgresql though my pidfile is in a different location. Could we allow an override in the configuration perhaps?

In the case above something like:

check service postgresql
    with pidfile "/run/postgreql/9.3-main.pid"

mperham commented 8 years ago

Put in a soft link?

On Feb 20, 2016, at 17:35, Jonathon W. Marshall notifications@github.com wrote:

I have the same issue with postgresql though my pidfile is in a different location. Could we allow and override in the configuration perhaps?

In the case above something like:

check service postgresql with pidfile "/run/postgreql/9.3-main.pid" — Reply to this email directly or view it on GitHub.

jwmarshall commented 8 years ago

Soft link works for me. But may not be ideal in all cases.

mperham / inspeqtor

PID detection is broken for sysvinit #117