mperrin / poppy

Physical Optics Propagation in Python
BSD 3-Clause "New" or "Revised" License
176 stars 41 forks source link

Arbitrary basis clipping fixes #241

Closed kvangorkom closed 7 years ago

kvangorkom commented 7 years ago
coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 65.432% when pulling e3c160ef5593e1d3aae16b47753e7d849f83d567 on kvangorkom:arbitrary_basis into 07036a0e43b2d662d1590ed24a19de3c3777ed1f on mperrin:master.

mperrin commented 7 years ago

The one travis test that failed is the docs build, which is unrelated to this and is caused (for no apparent reason?) by my having merged #234 yesterday. This fix looks good and all the actual code tests pass so I'm going to go ahead and merge it. Thanks @kvangorkom

douglase commented 7 years ago

The same doc error appears to be the problem with #239, has something changed in the sphinx library?

On Tue, Nov 14, 2017 at 15:32 Marshall Perrin notifications@github.com wrote:

The one travis test that failed is the docs build, which is unrelated to this and is caused (for no apparent reason?) by my having merged #234 https://github.com/mperrin/poppy/pull/234 yesterday. This fix looks good and all the actual code tests pass so I'm going to go ahead and merge it. Thanks @kvangorkom https://github.com/kvangorkom

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mperrin/poppy/pull/241#issuecomment-344388627, or mute the