search

mperrin / poppy

Physical Optics Propagation in Python
BSD 3-Clause "New" or "Revised" License
173 stars 40 forks source link

Fix type of beam_ratio in FresnelOpticalWavefront #258

Closed sdwill closed 6 years ago

sdwill commented 6 years ago

The beam_ratio parameter is specified as int, but should be float, since it is given by 1/Q, where Q is the integer entrance pupil padding factor.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.6%) to 64.165% when pulling 929f285382fa4c50a13149d84a57fa3bec8a12af on sdwill:master into bc8435848636e6836118cf9d23628cb822021637 on mperrin:master.

mperrin commented 6 years ago

Thanks @sdwill, good catch.