search

mperrin / poppy

Physical Optics Propagation in Python
BSD 3-Clause "New" or "Revised" License
173 stars 40 forks source link

Full implementation of fwcentroid #272

Open alexhelms opened 1 month ago

alexhelms commented 1 month ago

Hi, thank you for creating this library!

I've been using poppy to generate stars for validation of some algorithms. I wanted to implement the fwcentroid function in C# but I noticed it is not fully implemented. I found the IDL code on your STScI site but as mentioned in the python comments, it is identical. I tried searching for the JWST technical reports JWST-STScI-001117 and JWST-STScI-001134 for details but am unable to find those anywhere online.

So that said, my question is are the technical reports and algorithm publicly available? If so, can you point me to them?

Thanks again!

mperrin commented 1 month ago

Hi @alexhelms, I'm not quite sure what you're referring to that's not fully implemented? I'll admit I have not looked at this code in a long time (~a decade) so the details are not fresh in my memory, to say the least.

I can dig up the old technical reports and share if needed. But I don't recall there being any significant part that was left out..

alexhelms commented 1 month ago

I'm referring to comments like https://github.com/mperrin/poppy/blob/a276feb4abf4e301912f355d567913a3b7222bae/poppy/fwcentroid.py#L78 and sections of commented out code like https://github.com/mperrin/poppy/blob/a276feb4abf4e301912f355d567913a3b7222bae/poppy/fwcentroid.py#L164

Perhaps these notes are just old and not relevant anymore but I figured I should ask. Thanks again.