search

mperrin / webbpsf

James Webb Space Telescope PSF simulation tool - NOTE THIS VERSION OF REPO IS SUPERCEDED BY spacetelescope/webbpsf
BSD 3-Clause "New" or "Revised" License
16 stars 15 forks source link

PEP8 and formatting in optics.py #142

Closed josePhoenix closed 7 years ago

josePhoenix commented 7 years ago

Some code polish and elbow grease for optics.py. Notably, this includes some class renames that were updated in webbpsf_core.py as well. I also moved the coordinate pairs for the JWST primary into a constants.py to improve the readability of optics.py. Here are the renames:

(My small act of protest of always referring to JWST rather than Webb ran up against the aesthetics of naming something JWSTOTEPupil and my activist side lost.)

mperrin commented 7 years ago

(My small act of protest of always referring to JWST rather than Webb ran up against the aesthetics of naming something JWSTOTEPupil and my activist side lost.)

Yeah, neither of those are great. I agree that "JWST" would be preferable in general (Overall it seems like people refer to the observatory less often as "Webb" these days than was common 5 or 6 years ago? But that's anecdotal, not data.) But that stack of capitalized letters isn't aesthetically pleasing. Even so I think it might be better to just go with JWSTOTEPupil and the like.

josePhoenix commented 7 years ago

It is WebbPSF, after all. WebbOTEPupil is growing on me.

mperrin commented 7 years ago

It is WebbPSF, after all. WebbOTEPupil is growing on me.

That reminds me of the question we've been dodging for a while, whether it should be instead WebbAndWFIRSTPSF (answer: no.) or something else entirely more inclusive (answer: maybe??) but rebranding would be a pain, so I'm still inclined to punt.

josePhoenix commented 7 years ago

Yes, let's kick that can down the road. (Maybe there's a Greek god or goddess of PSFs? Worked for the ETC people...)