search

mperrin / webbpsf

James Webb Space Telescope PSF simulation tool - NOTE THIS VERSION OF REPO IS SUPERCEDED BY spacetelescope/webbpsf
BSD 3-Clause "New" or "Revised" License
16 stars 15 forks source link

Uncompressed OPD files #173

Closed JarronL closed 7 years ago

JarronL commented 7 years ago

OPD files have much faster access times if they are uncompressed FITS files (.fits) as opposed to .fits.gz. The suggested code change allows searching of the OPD directory for either extension type.

mperrin commented 7 years ago

Looks good, thanks. :-) I've reviewed your code changes and our automated unit tests pass so this is definitely good to merge. (And welcome to the contributors for this project!)

JarronL commented 7 years ago

What are these "automated unit tests" and how do I get them? They sound really useful!

mperrin commented 7 years ago

Ah, software testing. Large topic. In the specific case of WebbPSF we have many dozens of test functions defined in webbpsf/tests which exercise various aspects of the software's behavior and test results against a variety of criteria. The test functions get ran automatically for every potential change and every committed change in the codebase on Github; furthermore the same tests are repeated on Python 2.7 and 3.6, and with several different versions of core libraries like astropy and numpy. If you look above in this PR page, you can find a link to see the details and can click through to see the test results on Travis, which is the cloud service that hosts the test runner.

For more on writing tests I will point you at https://docs.pytest.org/en/latest/ or perhaps https://jeffknupp.com/blog/2013/12/09/improve-your-python-understanding-unit-testing/