search

mperrin / webbpsf

James Webb Space Telescope PSF simulation tool - NOTE THIS VERSION OF REPO IS SUPERCEDED BY spacetelescope/webbpsf
BSD 3-Clause "New" or "Revised" License
16 stars 15 forks source link

Redundant code in _get_aberrations #186

Closed shanosborne closed 6 years ago

shanosborne commented 6 years ago

Clean up redundant code (the error) in _get_aberrations function in core code

robelgeda commented 6 years ago

Hi @shanosborne, what is the error in _get_aberration?

mperrin commented 6 years ago

Hi Robel, thanks for asking but this doesn’t need your attention - Shannon is getting up to speed to contribute to WebbPSF also. There’s not an error per se, but we were looking through the code yesterday and noticed some redundant/unnecessary code that could be cleaned up. So that is a good exercise for her to get up to speed with working with github pull requests etc. Speaking of which I saw you just commented on several - stand by...

robelgeda commented 6 years ago

Sounds good to me!

mperrin commented 6 years ago

Closed by PR #189.

(BTW, @shanosborne, a helpful feature on Github is that when you do a pull request that fixes an issue, you can include a string like "closes #186" as part of the Git commit message. Then Github will automatically know to mark the issue as closed when the PR is merged. See these GitHub docs for details. Or you can come and manually comment that the issue should be closed, like this!)