search

mperrin / webbpsf

James Webb Space Telescope PSF simulation tool - NOTE THIS VERSION OF REPO IS SUPERCEDED BY spacetelescope/webbpsf
BSD 3-Clause "New" or "Revised" License
16 stars 15 forks source link

Improved: SI WFE interpolation #187

Closed robelgeda closed 6 years ago

robelgeda commented 6 years ago

Improved version of PR #174. Zernike values are interpolated using scipy.interpolate.griddata's cubic method. This gives the best approximations and adds smallest overhead.

mperrin commented 6 years ago

I'm confused - what is improved in this versus #174? Looks identical to me.

mperrin commented 6 years ago

Is the only difference the call to np.isnan() for checking for invalid interpolation outputs and then using the nearest neighbor instead?

robelgeda commented 6 years ago

Yes, also the range of the Zernike for loop should be 1->37 instead of 1->36.

robelgeda commented 6 years ago

@mperrin I fixed the conflict. At this point the only difference is the for loop range.

mperrin commented 6 years ago

OK, it looks like the actual code tests are fine for this; the Travis build is failing because of the docs issue (#193), not because of this change. So I'm going to go ahead and merge it.

@robelgeda, any chance you might be able to try to dig into the docs build problems (for webbpsf and poppy both) over the next few days sometime? See #193.