mperrin / webbpsf

James Webb Space Telescope PSF simulation tool - NOTE THIS VERSION OF REPO IS SUPERCEDED BY spacetelescope/webbpsf
BSD 3-Clause "New" or "Revised" License
16 stars 15 forks source link

Detector pixel coordinate specification isn't necessarily consistent with odd/even array sizes #200

Closed mperrin closed 6 years ago

mperrin commented 6 years ago

As discussed with @shanosborne

Consider:

fgs = FGS()
fgs.detector_position= (100,400)
psf = fgs.calc_psf(fov_pixels=100)

The resulting PSF has even dimensions so it's exact center is implicitly on a half pixel boundary. The detector position coordinates written into the FITS header should probably be modified to reflect that.

Could also consider giving the mapping to the detector pixel coordinates of the first pixel (data[0,0]) in the array? Need to be more thoughtful about the precise consistency of this with the SIAF values.

mperrin commented 6 years ago

@shanosborne is fixing this

mperrin commented 6 years ago

Fixed by #205