Open mperrin opened 6 years ago
From Randal regarding the defocus/wavelength function. "The best thing to do is to synthesize all of our ISIM CV and NIRCam CV tests into a consistent model. I still haven’t written up my OTIS reports so I need to get that out the door first, but after that I will get back to this older stuff, that one is definitely on my list to do."
I'll look into my old CV3 analysis of the best focus positions. I used encircle energy fractions to estimate the best focus for CV3 observations and I was usually in good agreement with everyone else values, including Randal's PR results (I was doing a cross-checked analysis). Maybe I can create my own defocus vs wavelength function.
@obi-wan76, @shanosborne could you help me update the checklist of tasks in this issue? I think a lot of these have been accomplished but it should be the two of you checking them off, not me. Thanks!
@mperrin how can edit this ticket to mark a task as complete? Thanks!
I believe you can just click on the checkboxes directly to mark them checked. Let me know if that doesn’t work.
@mperrin I tried but I can't check the checkboxes. I see it as "unclickable". @shanosborne are you able to check the checkboxes? Perhaps is just me.
No I also can't click the checkboxes
Bah, that's annoying. Well then just add comments here saying what's been done and I will update.
@obi-wan76 Did you ever decide if we should update the focus vs wavelength model for NIRCam at all? Right now since we’re basically ready to go with everything else, I’m inclined to leave any changes to the focus model for a future task. Yes?
@mperrin Yes. I think we need to wait for Randal's final report to include a field-dependent focus model. I got some DMS reprocess NIRCam CV3 data to work on my own corrections but we still have time to compile and upgrade to a final all-inclusive model (as a future task).
We did most of this for 0.7, but I'm leaving it open for 0.7.1 to remind us that we wanted to improve the NIRCam focus model based on the outcome of Randal's analyses.
Notes from discussion with Marcio and Shannon - cc @shanosborne, @obi-wan76
SI defocus models
Pupil shear and pupil distortions.
To the extent that pupil distortions are in the SIAF, this will be automatically handed by @shanosborne's new code for applying distortions.
Same for the pupil rotations mostly. The default per each SI was taken from the SIAF a while ago, and hard-coded into webbpsf_core.
Pupil shear/offsets. Doesn't matter for imaging modes with clear pupils. Does matter for modes with additional pupil obscurations inside the SIs, in particular the NIRCam and MIRI coronagraph modes. See Table 19 of Aronstein's WFE report.
__init__
functions to setoptions[pupil_shift_x]
,options[pupil_shift_y]
to the values from the report.SI WFE Zernikes
Pupil Map resolution for large FOV PSFs, and incoherent scattered light
[ ] @mperrin, @obi-wan76 can collaborate to make it easier to use the 2048 squared OPDs. If the user selects a 2048 sized pupil, the OPDs should all be upsampled to match automatically.
Other