Make add_distortion work with any output_mode

shanosborne commented 6 years ago

Changes:

add_distortion and crop_psf are now set in the options dictionary in the calc_psf function
The "if add_distortion" section was moved to the new _calc_psf_format_output function (and removed from the calc_psf function)
All the functions in distortion.py were updated to edit only on 1 extension
A test was added to test_webbpsf.py to test future edits that setting the output_mode doesn't break anything

This is part of fix to allow distortion to be added to WebbPSF PSFs with any output_mode. (The other part of this fix is in Poppy)

coveralls commented 6 years ago

Coverage decreased (-0.09%) to 38.156% when pulling 6b27d0c9a676d4923440c8f5cc608d80e1fbad10 on shanosborne:bug_fixes into 73406e8ef01b7551432a6e781102c0641b61d881 on mperrin:master.

mperrin commented 6 years ago

Looks good, thanks @shanosborne. By the way have you yet told Kevin that this fix is available now? If not I'm sure he would appreciate hearing that.

shanosborne commented 6 years ago

@mperrin - yes I have emailed Kevin. Thanks for the merge!

mperrin / webbpsf

Make add_distortion work with any output_mode #219