search

mperrin / webbpsf

James Webb Space Telescope PSF simulation tool - NOTE THIS VERSION OF REPO IS SUPERCEDED BY spacetelescope/webbpsf
BSD 3-Clause "New" or "Revised" License
16 stars 15 forks source link

WFIRST changes without any GUI stuff #41

Closed josePhoenix closed 9 years ago

josePhoenix commented 9 years ago

This includes some rearranging of stuff in JWInstrument to create a SpaceTelescopeInstrument class as a common base for JWST and WFIRST. It also loads instrument filters the "new" way, from an instrument-specific table rather than one big table for all.

mperrin commented 9 years ago

@josePhoenix this PR can no longer be merged automatically - could you try merging master back into your branch?

Also I've now gotten Travis working for WebbPSF as well as Poppy so I think we ought to be able to use it to check the PR passes all tests, if you update the PR again to trigger a build.

josePhoenix commented 9 years ago

Updated! The build probably won't work yet, for reasons we discussed by email.

mperrin commented 9 years ago

Since this needs the filter information split out into separate .tsv files, can you send me all those before I merge this? Thanks.

josePhoenix commented 9 years ago

Hmm, I seem to remember that we copied those into the instrument sub folders in /grp/jwst/ote/webbpsf-data. I can't check from here, but if they're not there I'll send them to you when I get in tomorrow.

On Feb 9, 2015, at 10:41 PM, Marshall Perrin notifications@github.com wrote:

Since this needs the filter information split out into separate .tsv files, can you send me all those before I merge this? Thanks.

\ Reply to this email directly or view it on GitHub.

mperrin commented 9 years ago

Ah OK right. I do have those files in /grp/jwst/etc, just not in the local copy on my desktop. Easy fix on my end. Thanks!