Closed josePhoenix closed 8 years ago
agreed re "maybe comment out the warning"
I think we should avoid writing our own version of a 'Jupyter for new users' basics tutorial, and instead have pointers to existing resources such as http://jupyter-notebook-beginner-guide.readthedocs.org/en/latest/
How much of this do you want to get done in the next 24 hrs for 0.4, versus punting to a hypothetical 0.4.1 in mid-December along with the jupyterhub rollout?
Most, if not all, is pretty straightforward. The only thing I told Roeland was not necessarily straightforward was customizing the appearance of some of the default plots (e.g. adding colorbars to the intermediate optical planes in the calcPSF(display=True)
call).
That said, the only thing I think is essential for the release is removing the GRS thing. I think I put that in for testing and never removed it... and it's only going to confuse people.
FYI, I removed the GRS top hat curve in the webbpsf data sources directory and in filters.tsv. I also doubled the nlambda for the wide filter. (We should come up with less-hand-wavey nlambda at some point, but I can't look at that right now.)
Closed by #83.
Based on feedback from @rpvdmarel (and things I noticed when looking with fresh eyes) I have a few things I / we should look at for notebook improvements:
There are certain FAQ items that don't have a good home, but should be discoverable from the notebook (what to do if the kernel dies / what that means, how to restart and clear output)display=True
in the PSF calculation call. Potentially add colorbars. (Does the last panel update with the broadband PSF in the last step? Or is that the last monochromatic step?)display_profiles
and mention the FWHM is markedGRS_throughput.fits
from the data package andfilters.tsv
image.interpolation
nearest
is set