search

mpetazzoni / leaflet-gpx

A GPX track plugin for Leaflet.js
http://mpetazzoni.github.io/leaflet-gpx
BSD 2-Clause "Simplified" License
529 stars 114 forks source link

Show kilometer and mile points #65

Closed astridx closed 4 years ago

astridx commented 6 years ago

I display the kilometers in my map. Maybe you like my suggestion. home

mpetazzoni commented 6 years ago

This is a cool feature! Could you clean it up a bit? In particular:

Finally, do you think there's a way to have this work without the additional CSS file? It would also be nice if those markers could be part of a feature group layer so they can easily be toggled on or off the map.

astridx commented 6 years ago

@mpetazzoni

I am glad that you like the feature. I tried to fulfill your wishes.

It is now possible to display points for kilometers and / or miles. There are also a few options for customizing the view.

The coding standards are a real challenge for me. I'm afraid you have to help me here again. Where can I read the standards?

The commit message wip was standing for 'work in progress'. Are the messages now OK for you?

I integrated the CSS in the script-and the markers are now part of a feature group layer. I hope you like the way I did this.

I would be very happy if you integrate my work.

finnito commented 5 years ago

Hi there!

I am happy to help resolve this conflict between the branches if someone could tell me how I can commit to this pull request.

I would love to see this feature merged!