removed apache commons-codec dependency for compability with android

mpetazzoni / ttorrent

BitTorrent Java library with tracker and download client

http://mpetazzoni.github.com/ttorrent/

Apache License 2.0

1.38k stars 502 forks source link

removed apache commons-codec dependency for compability with android #163

Closed vauvenal5 closed 8 years ago

vauvenal5 commented 8 years ago

With this change the ttorrent library works on android. The actual issue is that Android has no support yet for commons-codec greater then 1.3

philipphenkel commented 8 years ago

Commons-codec was removed with commit 7fc52791f9e70af40c42893c523795eb4cf09ca0 Remove dependency on Apache commons-codec

vauvenal5 commented 8 years ago

Okay, thx. Seems like I should have send in the PR earlier.

XenonRaite commented 8 years ago

public static String byteArrayToHexString(byte[] bytes) { return new String(Hex.encodeHex(bytes, false)); return new BigInteger(1, bytes).toString(16); }

Leading 0 is missing in the output. This method used many times. I think that can be a problem. Expected String is 00d7680d04149f32a0f954d073e259745e11aa60 but i get d7680d04149f32a0f954d073e259745e11aa60 I like this pull request to apply for fix it.

philipphenkel commented 8 years ago

Good catch. I submitted a fix + some tests for that function, see #174

mpetazzoni commented 8 years ago

Nice. Thanks!