search

mpeterv / argparse

Feature-rich command line parser for Lua
MIT License
251 stars 43 forks source link

Very trivial issue - argparse.version #21

Closed stone1343 closed 4 years ago

stone1343 commented 5 years ago

Hi, I love that you've added argparse.version in v0.6.0, just a very trivial comment, I think the "Lua way" to do this is argparse._VERSION.

Feel free to reject this defect if I'm off-base.

Thanks

Jeff

daurnimator commented 5 years ago

_VERSION is sort of a weird one: it was the traditional name for the field; yet Lua has always reserved names starting with underscore. With the Lua 5.3 release, this was formalised better in the lua manual:

As a convention, programs should avoid creating names that start with an underscore followed by one or more uppercase letters (such as _VERSION).

I would say that is definitive enough to reject this proposal. (Could you please close this issue?)

stone1343 commented 4 years ago

Thanks for feedback, closing as requested