search

mpeterv / argparse

Feature-rich command line parser for Lua
MIT License
251 stars 43 forks source link

Added license to top of argparse.lua. #3

Closed jsbackus closed 9 years ago

jsbackus commented 9 years ago

Hi,

I'm working on packaging argparse for Fedora. One of the requests I received was to put the license at the top of argparse.lua. Please consider doing so.

Thanks!

Regards, Jeff

mpeterv commented 9 years ago

Hi, I don't mind merging this but I'm wondering why it is recommended. I took a look at Fedora licensing guidelines and as I understand it, having license text in a separate file (LICENSE) is enough.

jsbackus commented 9 years ago

Hi Peter,

Yes, having the LICENSE file is enough to meet guidelines, however the preference is to have the license info at the top of every file, in case someone borrows some of your code to use elsewhere. Since there is only one file of note in your project, the review strongly encouraged adding the license info to the top. I suspect this is one of those things that varies widely reviewer to reviewer.

Regards, Jeff

mpeterv commented 9 years ago

I see, merging this. I'll release 0.4.1 version tomorrow.

jsbackus commented 9 years ago

Hi Peter,

Great! Thanks!

Regards, Jeff