Fix Python 3 compatibility on error

mpeterv / hererocks

Python script for installing Lua/LuaJIT and LuaRocks into a local directory

MIT License

180 stars 22 forks source link

Fix Python 3 compatibility on error #15

Closed Lekensteyn closed 8 years ago

Lekensteyn commented 8 years ago

This fixes a "TypeError: write() argument must eb str, not bytes" when the compilation command fails.

(discovered this when trying to invoke hererocks on Windows which failed due to missing GCC)

mpeterv commented 8 years ago

Thanks! By the way Windows is not yet supported completely, I should mention that in the docs.

Lekensteyn commented 8 years ago

Yes, I am working on Windows support now (for #8). The changes are not that evasive, but right now luarocks removes the prefix, so I guess I have to patch the Luarocks installer script.