search

mpeterv / hererocks

Python script for installing Lua/LuaJIT and LuaRocks into a local directory
MIT License
180 stars 22 forks source link

The current master is broken for LuaJIT #4

Closed jirutka closed 8 years ago

jirutka commented 8 years ago

Something went wrong. When I use hererocks.py from the current master, then nginx build with nginx-lua-module fails https://travis-ci.org/jirutka/ngx-oauth/jobs/94990859.

I’ll try to find which commit is responsible for this and provide more details later.

jirutka commented 8 years ago

By the way, it’s broken in very weird way, this build doesn’t fail on my machine (OS X), but LuaJIT (loaded by nginx) fails to require any Lua module. It took me an hour before I finally figured out where the heck is the problem (yeah, I’m an idiot, I have used the master version of hererocks instead of the last tagged version).

mpeterv commented 8 years ago

Seems that b017fbc broke installation of luajit libs, unfortunately I don't have tests for that - luarocks doesn't need the libs.

mpeterv commented 8 years ago

Fixed on master branch (https://travis-ci.org/mpeterv/ngx-oauth/builds/95532191), but indeed you should use the tagged version. Although I don't think I'd have caught this bug before release by myself, thanks!

jirutka commented 8 years ago

Great, thanks! I guess we can close this issue.