mpeterv / luacheck

A tool for linting and static analysis of Lua code.
MIT License
1.92k stars 322 forks source link

Force lower-case during path normalization. #150

Closed FireSiku closed 6 years ago

FireSiku commented 6 years ago

File paths are never case-sensitive. This fixes an issue that leads to false negatives when matching globs.

mpeterv commented 6 years ago

File paths are typically case-sensitive outside Windows.

codecov-io commented 6 years ago

Codecov Report

Merging #150 into master will decrease coverage by 0.2%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #150      +/-   ##
==========================================
- Coverage   97.77%   97.56%   -0.21%     
==========================================
  Files          35       35              
  Lines        4800     4801       +1     
==========================================
- Hits         4693     4684       -9     
- Misses        107      117      +10
Impacted Files Coverage Δ
src/luacheck/fs.lua 88.17% <100%> (-3.14%) :arrow_down:
src/luacheck/lua_fs.lua 84% <0%> (-12%) :arrow_down:
src/luacheck/config.lua 91.86% <0%> (-1.63%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3fc4ff...1cea9d2. Read the comment docs.

FireSiku commented 6 years ago

Oh. Right. Guess it never came up in my time using Ubuntu so brain just forgot about it. Fixed it.

mpeterv commented 6 years ago

Thank you!