search

mpetroff / pannellum

Pannellum is a lightweight, free, and open source panorama viewer for the web.
https://pannellum.org/
MIT License
4.23k stars 722 forks source link

iphone workaround for fullscreen #1132

Closed the-ft closed 1 year ago

the-ft commented 1 year ago

this is a workarround for the unsupported fullscreen api on ios (iphones/ipads). i have added a new config value "workaroundFullscreen" (by default on) which now forces to show the fullscreen button. on click it maximizes, additionally to the fullscreen api function, the pannellum container class. so if the api is not working, you still get something like a fullscreen inside the browser. on iphones it now looks like a fullscreen.

the config value is not really needed nor really useful. it was just a switch for the workarround to check the difference. i didnt wanted to throw the whole logic upside down. please change this as you see fit.

mpetroff commented 1 year ago

I'm not in favor of adding a kludge just because Apple can't be bothered to support a widely-supported feature of the web platform. Complain to Apple about them not supporting the fullscreen API.

mpetroff commented 1 year ago

There was nothing wrong with your pull request. It's just not something I want to include.

the-ft commented 1 year ago

dont worry, i'm not offended 😉. your point is legit, noone likes to mess up their code. it s like supporting a particular kind of personality disorder by making open source available to everyone, even those with high entitlement to special treatment. who will or should give in?