search

mpetroff / pannellum

Pannellum is a lightweight, free, and open source panorama viewer for the web.
https://pannellum.org/
MIT License
4.23k stars 722 forks source link

Add pannellumloaded event dispatched from standalone.js #1140

Closed trey0 closed 1 year ago

trey0 commented 1 year ago

Hi! I'm a first-time contributor.

We are working on a panoramic tour of the International Space Station and wanted to include a custom overview map widget in the upper right corner of the Pannellum display. (You can see a screen shot below; the red arrow in the overview map moves according to which scene is loaded, and rotates as the yaw changes.)

We were able to develop the map widget and use it along with the standalone Pannellum viewer almost unmodified. We just needed a small modification to trigger an event we call pannellumloaded, which our code can use to trigger setup of our custom widget in the context of the main Pannellum display.

We're very happy with Pannellum and we can continue using our fork without problems, but we thought others in a similar position might find this event useful.

Thanks for all your effort maintaining Pannellum!

![image](https://user-images.githubusercontent.com/190582/214718810-748985b3-c768-42d1-bfca-513bef0e0a08.png

mpetroff commented 1 year ago

The standalone viewer is intended for simple display of panoramas and nothing more complicated. I intend the JavaScript API interface for such more complicated applications. Thus, I'm not going to merge this pull request.

However, I'm glad it works for you! Since you've only modified the standalone.js file, I hope maintaining a vendored copy isn't too much work for you. You're effectively using the API, but with the standalone viewer as an example / starting template.