mpetroff / pannellum

Pannellum is a lightweight, free, and open source panorama viewer for the web.
https://pannellum.org/
MIT License
4.15k stars 710 forks source link

Black squares on multires panorama on low screen size #1204

Closed ArFnds closed 4 months ago

ArFnds commented 4 months ago

When displaying the multires example on mobile, or by adjusting the width, some tiles does not display :

image image

Step to reproduce:

Looks like this one : #786

mpetroff commented 4 months ago

Which version of Pannellum and what browser and browser version are you using?

In #786, the issue was that there were missing tiles while the panorama was loading (which has since been resolved with the addition of spherical harmonics based previews). My interpretation of what you're reporting is that the tiles never load, which would be a different issue.

ArFnds commented 4 months ago

I have build the project from the master branch.

Mobile:

On mobile, the black squares disappear after a few moment, it seems to load little tiles. But I am on the same Wifi as my computer (which has no problem on full size), and my phone is not old (Samsumg S21).

Maybe le tiles are loaded again and again from internet, which can cause this "always loading tiles issue" on mobile.

I may not be pointing the right problem. Here is a gif of the issue when resizing on computer : https://freeimage.host/i/J0Dj0vI

mpetroff commented 4 months ago

This was a regression due to a bug in an optimization introduced in 05dae19b2806fd01665351ab0f83a8bd203494ed. I fixed the bug in 8f7a888c3a108b2bcf9b961341bb0faa4ce627d3 and further improved the optimization in 021b512fa80f0e987332d11debe14a4cc55052d7, which reduces the unnecessary drawing of tiles that have their children drawn on top of them, reducing the total number of draw calls per frame.