search

mpetroff / pannellum

Pannellum is a lightweight, free, and open source panorama viewer for the web.
https://pannellum.org/
MIT License
4.15k stars 710 forks source link

Add typescript definitions on DefinitelyTyped #1220

Open zhirzh opened 3 weeks ago

zhirzh commented 3 weeks ago

Hi @mpetroff. I have added pannellum types on DefinitelyTyped and would like you to review them. If any changes are needed, I'd be happy to patch things up.

mpetroff commented 2 weeks ago

I don't use TypeScript, but I'm not sure you properly captured the panorama option when the dynamic option is set to true. In this case, the panorama option accepts anything that the pixels argument to texImage2D accepts. It looks to me that you're forcing the panorama option to be a string.