search

mpetroff / pannellum

Pannellum is a lightweight, free, and open source panorama viewer for the web.
https://pannellum.org/
MIT License
4.29k stars 726 forks source link

Is there support for partial / cylindrical panoramas? #75

Closed fuzzybabybunny closed 9 years ago

fuzzybabybunny commented 9 years ago

Does this support partial panoramas such as 270 degree panos that also don't extend completely to the top or bottom?

mpetroff commented 9 years ago

There is support for partial panoramas, but only if they are in an equirectangular projection. See the haov, vaov, and vOffset parameters.

DDvO commented 7 years ago

I meanwhile managed to generalize the generate.py script to support cylindrical input and to adapt the Python and JavaScript sources to support partial panoramas (from both equirectangular/spherical and cylindrical input) without wasting space and communication bandwidth on tile files that represent areas never shown. I can share the details in case you're interested.

Here is an example partial cylindrical pano generated this way.

jens-eggers commented 6 years ago

Hi @DDvO , I really like your work on cylindrical panoramas for pannellum looking at your page! I also have a lot of these source files, did you manage to enable pannellum to accept these? How can I adapt these changes, that would be very interesting. Can you please share the details?

DDvO commented 6 years ago

Hi @jens-eggers , pleased to hear. All right, today I've started setting up a series of pull requests that touch various more or less independent aspects of the extensions I made for supporting partial panoramas of cylindrical and other types. Here is the first of them: https://github.com/mpetroff/pannellum/pull/562

DDvO commented 6 years ago

I've just extended my PR #570 which concludes the additions needed to support partial / cylindrical panoramas.

jens-eggers commented 6 years ago

Hi David, sorry for my late reply. I will have a deeper on what you have mentioned during next week. In the meantime I "cheated" a little having a look at the example you provided, which already helped me a lot on creating a full 360° cylindrical view. Understanding the parameters was the key.

Thank you very much for your reply, I appreciate it!

Best regards, Jens

David von Oheimb notifications@github.com schrieb am Sa., 17. März 2018, 20:15:

I've just extended my PR #570 https://github.com/mpetroff/pannellum/pull/570 which concludes the additions needed to support partial / cylindrical panoramas.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mpetroff/pannellum/issues/75#issuecomment-373945484, or mute the thread https://github.com/notifications/unsubscribe-auth/AjLiGTkh9kKjpvppj1u59ZuGybOlEr5Xks5tfWC3gaJpZM4EmDKx .

DDvO commented 6 years ago

Hi Jens, you are welcome. Meanwhile the pull request mentioned above is merged, so in my view partial / cylindrical panoramas can now be considered officially supported.

Talking of parameters, the key options of generate.py for cylindrical input are