mpetrovich / stylemark

Generate interactive style guides from Markdown.
MIT License
218 stars 35 forks source link

hiding external files does not work #39

Closed sir-marc closed 6 years ago

sir-marc commented 6 years ago

The possibility to hide inline 'files' works just fine, but when trying to hide an external file it doesn't really work properly. For example this works just fine:

```types.css hidden
body {
  background-color: red;
}```

whereas this does not work:

```types:../lib/style.css hidden```

It justs displays the content of the file in plain text inside the markup, see attached screenshot bildschirmfoto 2018-06-07 um 17 41 43

mpetrovich commented 6 years ago

Thanks for reporting! We'll fix this soon.

mpetrovich commented 6 years ago

@sir-marc What version of Stylemark are you using? This works in v3.0 and was likely fixed in v1.0.1. Please upgrade to v2.x or greater and retest (v1.x is deprecated).

sir-marc commented 6 years ago

@mpetrovich We are using version 3.0

StuckiSimon commented 6 years ago

@mpetrovich I've setup a quick repo using 3.0.0 to reproduce the issue: Stylemark Issue #39.

The generated stylemark documentation is available under: Demo

mpetrovich commented 6 years ago

This is was a weird one. When the external stylesheet has an empty newline at the end of the file, it works. But when it doesn't (in your case), it's not being handled correctly. Fixing now.

mpetrovich commented 6 years ago

Fixed in v3.0.1

mpetrovich commented 6 years ago

FYI in case it's relevant, along the way I discovered a bug with the way external wildcard references are handled: https://github.com/nextbigsoundinc/stylemark/issues/41