Make framework scripts conditional - Githubissues

mpetrovich / stylemark

Generate interactive style guides from Markdown.

MIT License

218 stars 35 forks source link

Make framework scripts conditional #73

Closed michaelw85 closed 5 years ago

michaelw85 commented 5 years ago

Moved angularjs, react and ember scripts out of the handlebars example into separate files and added conditional checks to add the scripts. Setup is done in a non breaking way, by default all scripts will be added.

Motivation for change:

Improve performance by centralizing the scripts preventing having to load the same code multiple times.
Add ability to omit all scripts when using a different setup/framework (in my case Aurelia)
Make it easy to overwrite the scripts if needed

michaelw85 commented 5 years ago

@mpetrovich Could you please review this change?