Zero radius bubbles on map

mpetyx / DarwinsMusic

The code for the mini project of the TooLate team on ESWC 2013

GNU Affero General Public License v3.0

3 stars 3 forks source link

Zero radius bubbles on map #2

Open gopalkoduri opened 11 years ago

gopalkoduri commented 11 years ago

Need to get rid of the bubbles which show up despite the artist popularity is zero for that decade/time-period.

zaen commented 10 years ago

I have looked into the source code of jVectorMap, the bubbles (called marker) will be drawn based on two data values:

hits for the color of the bubbles
listeners for the size of the bubbles

I found several data have zero values for listeners but non-zero for their hits. For those cases of course we will not be able to draw a color for bubbles with zero width.

I still not able to filter the data with zero values of both types yet.

For temporary solution, The label for a zero value (hits/listener) will be hidden.

mpetyx commented 10 years ago

if you just give no values when it's zero? so you have totally empty values? does it work like that?

zaen commented 10 years ago

Michael, I think I found the bug.

There is no problem whenever the zero values are in hits dataset (hits does not affecting the size of the bubble)
There is no problem as well whenever the zero values are in listeners dataset (the bubble will be hidden due to zero radius)

The problem occurs whenever the number of items in hits dataset more than items in listeners dataset. The jVectorMap will be automatically create a dummy bubble to draw the color of hits for each non-exist item in listeners dataset.

I have tried to balance the number of items from both datasets, but on screen a dot still occurs for zero radius. I am thinking to normalize the data.

mpetyx commented 10 years ago

hm.. this seems quite normal i think. if you find nothing on that, let me know and i could may normalize it server side

zaen commented 10 years ago

The jVectorMap has option "normalizeFunction" and "linear" function is applied by default. I have re-balanced the number of items from both datasets by pushing couple of zeros into the listeners (which are later on will be used as the radius for the bubbles, bubbles with zero radius should be disappear). It seems to be working on my machine, please test on your machine.