mpeylo / cmpossl

An OpenSSL-based implementation of the Certificate Management Protocol (CMP), defined in IETF RFCs 4210, 4211, and 6712. It is being extended according to the emerging RFCs 'CMP Updates' (CMPv3), 'CMP Algorithms', and 'Lightweight CMP Profile'.
https://github.com/mpeylo/cmpossl/wiki
Other
35 stars 13 forks source link

Have CTX functions to get info relevant for transfer Callback #102

Closed tpank closed 6 years ago

tpank commented 6 years ago

CMP_PKIMESSAGE_http_perform() could be overwritten by means of a callback.

Ensure best practice information hiding by having access functions allowing to get the relevant information without needing to know the internal structure of ctx.

ctx->msgTimeOut ctx->serverName ctx->serverPort ctx->tlsBIO <-- maybe not needed ctx->proxyName ctx->proxyPort

others?

Also add a void pointer to the ctx to allow handing other possibly relevant information to the transfer function, e.g. source IP.

Reported by: mpeylo

Original Ticket: cmpforopenssl/feature-requests/48

tpank commented 6 years ago

Diff:


--- old
+++ new
@@ -6,6 +6,8 @@
 ctx->serverName
 ctx->serverPort
 ctx->tlsBIO <-- maybe not needed
+ctx->proxyName
+ctx->proxyPort

 others?

Original comment by: mpeylo

tpank commented 6 years ago

Original comment by: mpeylo