Closed raja-ashok closed 5 years ago
Requesting @mpeylo and @DDvO to review and provide comments on this.
Looks sensible to me. I speculate that @DDvO will have a look at this as soon as he is available, while you might need to be patient as there might be summer vacation time at his location.
Ok Sure. Thanks for your response.
Thanks for the suggestion.
Good idea to be defensive on negative ctx->totaltimeout
values potentially given.
Yet in your PR the new comparisons should not read ctx->totaltimeout >= 0
but ctx->totaltimeout > 0
.
Yaa, you are correct. I will fix it.
I can see that you force-pushed on the branch, but I cannot see the necessary change from >=
to >
.
BTW, for the assignment to ctx->end_time
the value does not matter in case totaltimeout <= 0
because then the variable is not used.
Done. Please check now.
merged; thanks!
Better to consider negative value configured to
totaltimeout
as 0 similar tomsgtimeout
.